Skip to content

fix: use boolean input for npm publish - #380

Merged
SonyLeo merged 1 commit into
opentiny:developfrom
gene9831:codex/fix-dispatch-publish-input
Jul 23, 2026
Merged

fix: use boolean input for npm publish#380
SonyLeo merged 1 commit into
opentiny:developfrom
gene9831:codex/fix-dispatch-publish-input

Conversation

@gene9831

@gene9831 gene9831 commented Jul 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the publishing workflow so component publishing is triggered properly when the publish option is enabled.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 349c46a3-f4d7-4b94-9c51-0d923d6b481d

📥 Commits

Reviewing files that changed from the base of the PR and between 93c4520 and 2fac867.

📒 Files selected for processing (1)
  • .github/workflows/dispatch-publish.yml

Walkthrough

The publish workflow now evaluates inputs.publish_npm as a boolean when deciding whether to run the “Publish components” step.

Changes

Publish workflow trigger

Layer / File(s) Summary
Boolean publish condition
.github/workflows/dispatch-publish.yml		 The “Publish components” step now directly evaluates inputs.publish_npm instead of comparing it with the string 'true'.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A bunny checks the switch with care,
Boolean truth now hops through air.
No string disguise, no puzzled glance,
The publish step gets its chance.
Hop, ship, and share!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the workflow change to treat the npm publish input as a boolean.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
.github/workflows/dispatch-publish.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Preview build completed successfully!

Click the image above to preview.
Preview will be automatically removed when this PR is closed.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📦 Package Preview

pnpm add https://pkg.pr.new/@opentiny/tiny-robot@2fac867

pnpm add https://pkg.pr.new/@opentiny/tiny-robot-kit@2fac867

pnpm add https://pkg.pr.new/@opentiny/tiny-robot-svgs@2fac867

commit: 2fac867

@SonyLeo
SonyLeo merged commit 47f98d6 into opentiny:develop Jul 23, 2026
4 checks passed
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🧹 Preview Cleaned Up

The preview deployment has been removed.

@gene9831
gene9831 deleted the codex/fix-dispatch-publish-input branch July 24, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SonyLeo SonyLeo SonyLeo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gene9831 @SonyLeo